aboutsummaryrefslogtreecommitdiffstats
path: root/lib/debugobjects.c
diff options
context:
space:
mode:
authorMax Yuan <maxyuan@google.com>2025-11-27 00:07:51 +0000
committerJakub Kicinski <kuba@kernel.org>2025-11-27 17:44:52 -0800
commit858b1d07e49106a302cc7c7fbeee4fb2698573c9 (patch)
treef6ced59e75aa7a0866b45bcf399f92ac3bdbd702 /lib/debugobjects.c
parent4c03592689bc19df9deda7a33d56c6ac0cec8651 (diff)
downloadnet-858b1d07e49106a302cc7c7fbeee4fb2698573c9.tar.gz
gve: Fix race condition on tx->dropped_pkt update
The tx->dropped_pkt counter is a 64-bit integer that is incremented directly. On 32-bit architectures, this operation is not atomic and can lead to read/write tearing if a reader accesses the counter during the update. This can result in incorrect values being reported for dropped packets. To prevent this potential data corruption, wrap the increment operation with u64_stats_update_begin() and u64_stats_update_end(). This ensures that updates to the 64-bit counter are atomic, even on 32-bit systems, by using a sequence lock. The u64_stats_sync API requires the writer to have exclusive access, which is already provided in this context by the network stack's serialization of the transmit path (net_device_ops::ndo_start_xmit [1]) for a given queue. [1]: https://www.kernel.org/doc/Documentation/networking/netdevices.txt Signed-off-by: Max Yuan <maxyuan@google.com> Reviewed-by: Jordan Rhee <jordanrhee@google.com> Signed-off-by: Harshitha Ramamurthy <hramamurthy@google.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'lib/debugobjects.c')
0 files changed, 0 insertions, 0 deletions