aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDouglas Anderson <dianders@chromium.org>2024-01-22 16:49:35 -0800
committerKees Cook <keescook@chromium.org>2024-01-22 17:42:09 -0800
commitedb6538da3df83806fffcfc1b873d0895c81b9e8 (patch)
treecf7ba264e02e5c0069e4275ab48917b4fe708f02
parent189a4edb774b9ee5daf345e703e53fffaf509285 (diff)
downloadtip-edb6538da3df.tar.gz
lkdtm/bugs: Adjust lkdtm_HUNG_TASK() to avoid tail call optimization
Notice: this object is not reachable from any branch.
When testing with lkdtm_HUNG_TASK() and looking at the output, I expected to see lkdtm_HUNG_TASK() in the stack crawl but it wasn't there. Instead, the top function on at least some devices was schedule() due to tail call optimization. Let's do two things to help here: 1. We'll mark this as "__noreturn". On GCC at least this is documented to prevent tail call optimization. The docs [1] say "In order to preserve backtraces, GCC will never turn calls to noreturn functions into tail calls." 2. We'll add a BUG_ON(1) at the end which means that schedule() is no longer a tail call. Note that this is potentially important because if we _did_ end up returning from schedule() due to some weird issue then we'd potentially be violating the "noreturn" that we told the compiler about. BUG is the right thing to do here. [1] https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html Signed-off-by: Douglas Anderson <dianders@chromium.org> Link: https://lore.kernel.org/r/20240122164935.2.I26e8f68c312824fcc80c19d4e91de2d2bef958f0@changeid Signed-off-by: Kees Cook <keescook@chromium.org>
Notice: this object is not reachable from any branch.
-rw-r--r--drivers/misc/lkdtm/bugs.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/misc/lkdtm/bugs.c b/drivers/misc/lkdtm/bugs.c
index b080eb2335eba8..d1222d3eda2f19 100644
--- a/drivers/misc/lkdtm/bugs.c
+++ b/drivers/misc/lkdtm/bugs.c
@@ -294,10 +294,11 @@ static void lkdtm_SPINLOCKUP(void)
__release(&lock_me_up);
}
-static void lkdtm_HUNG_TASK(void)
+static void __noreturn lkdtm_HUNG_TASK(void)
{
set_current_state(TASK_UNINTERRUPTIBLE);
schedule();
+ BUG_ON(1);
}
static volatile unsigned int huge = INT_MAX - 2;