diff options
| author | Jeff Layton <jlayton@kernel.org> | 2025-11-11 09:12:50 -0500 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2025-11-12 09:38:36 +0100 |
| commit | 85bbffcad7307e2ca6136be657cc21b0e1c42241 (patch) | |
| tree | d1ac64d2179f773bc2e1644cdc53d584ac2c6b94 /fs/open.c | |
| parent | 134796f43a5e6542546841ebecc7465e6f6a96d2 (diff) | |
| download | tip-85bbffcad7307e2ca6136be657cc21b0e1c42241.tar.gz | |
vfs: clean up argument list for vfs_create()
As Neil points out:
"I would be in favour of dropping the "dir" arg because it is always
d_inode(dentry->d_parent) which is stable."
...and...
"Also *every* caller of vfs_create() passes ".excl = true". So maybe we
don't need that arg at all."
Drop both arguments from vfs_create() and fix up the callers.
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: NeilBrown <neil@brown.name>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Link: https://patch.msgid.link/20251111-dir-deleg-ro-v6-9-52f3feebb2f2@kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/open.c')
| -rw-r--r-- | fs/open.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/open.c b/fs/open.c index fdaa6f08f6f4ca..e440f58e3ce81e 100644 --- a/fs/open.c +++ b/fs/open.c @@ -1171,9 +1171,7 @@ struct file *dentry_create(const struct path *path, int flags, umode_t mode, if (IS_ERR(f)) return f; - error = vfs_create(mnt_idmap(path->mnt), - d_inode(path->dentry->d_parent), - path->dentry, mode, true); + error = vfs_create(mnt_idmap(path->mnt), path->dentry, mode); if (!error) error = vfs_open(path, f); |