diff options
| author | Michael Paquier | 2025-12-15 01:28:28 +0000 |
|---|---|---|
| committer | Michael Paquier | 2025-12-15 01:28:28 +0000 |
| commit | 171198ff2a57fafe0772ec9d3dfbf061cffffacd (patch) | |
| tree | 15a168c9d7e455c4defdb60556033f64f7915ab0 | |
| parent | 481783e69f144936f1ebbc3259809bee518c6c0c (diff) | |
pageinspect: use index_close() for GiST index relation
gist_page_items() opens its target relation with index_open(), but
closed it using relation_close() instead of index_close(). This was
harmless because index_close() and relation_close() do the exact same
work, still inconsistent with the rest of the code tree as routines
opening and closing a relation based on a relkind are expected to match,
at least in name.
Author: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/CAEoWx2=bL41WWcD-4Fxx-buS2Y2G5=9PjkxZbHeFMR6Uy2WNvw@mail.gmail.com
| -rw-r--r-- | contrib/pageinspect/gistfuncs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/pageinspect/gistfuncs.c b/contrib/pageinspect/gistfuncs.c index de3746a156b..414513c395b 100644 --- a/contrib/pageinspect/gistfuncs.c +++ b/contrib/pageinspect/gistfuncs.c @@ -361,7 +361,7 @@ gist_page_items(PG_FUNCTION_ARGS) tuplestore_putvalues(rsinfo->setResult, rsinfo->setDesc, values, nulls); } - relation_close(indexRel, AccessShareLock); + index_close(indexRel, AccessShareLock); return (Datum) 0; } |