diff options
| author | Peter Eisentraut | 2024-09-03 06:00:38 +0000 |
|---|---|---|
| committer | Peter Eisentraut | 2024-09-03 06:06:03 +0000 |
| commit | 2b5f57977f6d16796121d796835c48e4241b4da1 (patch) | |
| tree | 995ebf254ffc97fa8f77dc16f3eb2fb0c3b6d252 /src/backend/access/transam/xloginsert.c | |
| parent | 4236825197e8b7f26f8fd2ce0ac287a696e7264e (diff) | |
Add const qualifiers to XLogRegister*() functions
Add const qualifiers to XLogRegisterData() and XLogRegisterBufData().
Several unconstify() calls can be removed.
Reviewed-by: Aleksander Alekseev <aleksander@timescale.com>
Discussion: https://www.postgresql.org/message-id/dd889784-9ce7-436a-b4f1-52e4a5e577bd@eisentraut.org
Diffstat (limited to 'src/backend/access/transam/xloginsert.c')
| -rw-r--r-- | src/backend/access/transam/xloginsert.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/src/backend/access/transam/xloginsert.c b/src/backend/access/transam/xloginsert.c index 90476015347..f92d0626082 100644 --- a/src/backend/access/transam/xloginsert.c +++ b/src/backend/access/transam/xloginsert.c @@ -72,7 +72,7 @@ typedef struct RelFileLocator rlocator; /* identifies the relation and block */ ForkNumber forkno; BlockNumber block; - Page page; /* page content */ + const char *page; /* page content */ uint32 rdata_len; /* total length of data in rdata chain */ XLogRecData *rdata_head; /* head of the chain of data registered with * this block */ @@ -138,7 +138,7 @@ static XLogRecData *XLogRecordAssemble(RmgrId rmid, uint8 info, XLogRecPtr RedoRecPtr, bool doPageWrites, XLogRecPtr *fpw_lsn, int *num_fpi, bool *topxid_included); -static bool XLogCompressBackupBlock(char *page, uint16 hole_offset, +static bool XLogCompressBackupBlock(const char *page, uint16 hole_offset, uint16 hole_length, char *dest, uint16 *dlen); /* @@ -307,7 +307,7 @@ XLogRegisterBuffer(uint8 block_id, Buffer buffer, uint8 flags) */ void XLogRegisterBlock(uint8 block_id, RelFileLocator *rlocator, ForkNumber forknum, - BlockNumber blknum, Page page, uint8 flags) + BlockNumber blknum, const char *page, uint8 flags) { registered_buffer *regbuf; @@ -361,7 +361,7 @@ XLogRegisterBlock(uint8 block_id, RelFileLocator *rlocator, ForkNumber forknum, * XLogRecGetData(). */ void -XLogRegisterData(char *data, uint32 len) +XLogRegisterData(const char *data, uint32 len) { XLogRecData *rdata; @@ -402,7 +402,7 @@ XLogRegisterData(char *data, uint32 len) * limited) */ void -XLogRegisterBufData(uint8 block_id, char *data, uint32 len) +XLogRegisterBufData(uint8 block_id, const char *data, uint32 len) { registered_buffer *regbuf; XLogRecData *rdata; @@ -648,7 +648,7 @@ XLogRecordAssemble(RmgrId rmid, uint8 info, if (include_image) { - Page page = regbuf->page; + const char *page = regbuf->page; uint16 compressed_len = 0; /* @@ -941,23 +941,23 @@ XLogRecordAssemble(RmgrId rmid, uint8 info, * the length of compressed block image. */ static bool -XLogCompressBackupBlock(char *page, uint16 hole_offset, uint16 hole_length, +XLogCompressBackupBlock(const char *page, uint16 hole_offset, uint16 hole_length, char *dest, uint16 *dlen) { int32 orig_len = BLCKSZ - hole_length; int32 len = -1; int32 extra_bytes = 0; - char *source; + const char *source; PGAlignedBlock tmp; if (hole_length != 0) { /* must skip the hole */ - source = tmp.data; - memcpy(source, page, hole_offset); - memcpy(source + hole_offset, + memcpy(tmp.data, page, hole_offset); + memcpy(tmp.data + hole_offset, page + (hole_offset + hole_length), BLCKSZ - (hole_length + hole_offset)); + source = tmp.data; /* * Extra data needs to be stored in WAL record for the compressed |