diff options
| author | Peter Eisentraut | 2019-06-05 20:55:16 +0000 |
|---|---|---|
| committer | Peter Eisentraut | 2019-06-06 08:14:25 +0000 |
| commit | f65eced25118aab29804debc4e0b9a67f4d043ad (patch) | |
| tree | 38e42811d3f36c7e5a441ab76e5a5fb8b56b776f /src/bin/pg_waldump/Makefile | |
| parent | cd96389d713787b025c84869ba417c6f2f008a86 (diff) | |
Previously, running pg_waldump with an invalid option (pg_waldump
--foo) would print the help output and exit successfully. This was
because it tried to process the option letter '?' as a normal option,
but that letter is used by getopt() to report an invalid option.
To fix, process help and version options separately, like we do
everywhere else. Also add a basic test suite for pg_waldump and run
the basic option handling tests, which would have caught this.
Diffstat (limited to 'src/bin/pg_waldump/Makefile')
| -rw-r--r-- | src/bin/pg_waldump/Makefile | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/bin/pg_waldump/Makefile b/src/bin/pg_waldump/Makefile index f5957bd75a..135979cef3 100644 --- a/src/bin/pg_waldump/Makefile +++ b/src/bin/pg_waldump/Makefile @@ -38,3 +38,10 @@ uninstall: clean distclean maintainer-clean: rm -f pg_waldump$(X) $(OBJS) $(RMGRDESCSOURCES) xlogreader.c + rm -rf tmp_check + +check: + $(prove_check) + +installcheck: + $(prove_installcheck) |