Skip to content

Conversation

@anone-zone
Copy link

tf2 branch for hl2sdk updated recently. Some members in IServer and IVEngineServer have changed.

@CookStar
Copy link
Contributor

Is it necessary to export IServer::GetPublicAddress?

@Ayuto
Copy link
Member

Ayuto commented Sep 20, 2021

No, we already have a Python function for it. Moreover, we would need to export netadr_t to actually be able to use it. I also tend to simply remove IsInternalBuild as it should always return True for us. Anyways, thanks for the PR! I you update the PR, I would like to merge it. Otherwise I'm going to make the changes on my own tomorrow.

@anone-zone
Copy link
Author

Thanks for the feedback. I've removed the extra functions.

@Ayuto
Copy link
Member

Ayuto commented Sep 20, 2021

Thank you!

@Ayuto Ayuto merged commit 70e71fe into Source-Python-Dev-Team:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants