Remove obsolete workaround for ESP8266 in compilation test CI workflow #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ESP8266 platform has a tool dependency on python3, but assumes that tool is already installed in a particular location on Linux. At the time this workaround was added, the Docker container used by the arduino/actions/libraries/compile-examples action did not provide this tool, so a workaround was needed to install it in the container. Since that time, the action has developed a dependency on Python, making this workaround unnecessary. The switch from the action being a Bash script to a Python script caused the now-unnecessary workaround to break the workflow.
aentinger
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ESP8266 platform has a tool dependency on python3, but assumes that tool is already installed in a particular location on Linux. At the time this workaround was added, the Docker container used by the arduino/actions/libraries/compile-examples action did not provide this tool, so a workaround was needed to install it in the container.
Since that time, the action has developed a dependency on Python, making this workaround unnecessary. The switch from the action being a Bash script to a Python script caused the now-unnecessary workaround to break the workflow.