[pluggable monitor] add documentation #1499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
requested changes
Oct 7, 2021
Co-authored-by: per1234 <accounts@perglass.com>
11914fa to
c8599ac
Compare
per1234
requested changes
Oct 7, 2021
Contributor
per1234
left a comment
There was a problem hiding this comment.
Just one last thing I forgot in my previous review: pluggable-monitor-specification.md should be added to the nav key of mkdocs.yml so that it will appear in the navigation pane of https://arduino.github.io/arduino-cli/dev/
Member
Author
|
done, also fixed a link in the source code |
per1234
approved these changes
Oct 7, 2021
Contributor
per1234
left a comment
There was a problem hiding this comment.
This will be a valuable resource for Arduino platform developers. Thanks Cristian!
58400af to
f6fd38a
Compare
d-a-v
pushed a commit
to d-a-v/arduino-cli
that referenced
this pull request
Oct 14, 2021
* Added documentation for pluggable monitor * Apply suggestions from code review Co-authored-by: per1234 <accounts@perglass.com> * Add pluggable monitor spec in nav bar; fixed link in source code comments * fix i18n and lint warnings Co-authored-by: per1234 <accounts@perglass.com>
d-a-v
added a commit
to d-a-v/arduino-cli
that referenced
this pull request
Oct 14, 2021
* Added documentation for pluggable monitor * Apply suggestions from code review Co-authored-by: per1234 <accounts@perglass.com> * Add pluggable monitor spec in nav bar; fixed link in source code comments * fix i18n and lint warnings Co-authored-by: per1234 <accounts@perglass.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Add docs for pluggable monitors.