Skip to content

[skip changelog] Handle non-board serial ports in compile integration tests #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
masci merged 1 commit into from
Jan 7, 2020
Merged

[skip changelog] Handle non-board serial ports in compile integration tests #539

masci merged 1 commit into from
Jan 7, 2020

Conversation

@federicobond
Copy link
Contributor

@federicobond federicobond commented Jan 5, 2020

The alternative is to change the code so that boards is always a non-null list.

masci
masci approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@masci masci changed the title Handle non-board serial ports in compile integration tests [skip changelog] Handle non-board serial ports in compile integration tests Jan 7, 2020
@masci masci merged commit c3b78f5 into arduino:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@masci masci masci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@federicobond @masci