Skip to content

Conversation

@rsora
Copy link
Contributor

@rsora rsora commented Apr 19, 2019

see for reference http://forum.arduino.cc/index.php?topic=610882
This PR was made on a windows system to be sure that the fix is real:

  • replace PathEscaping with encoding in base64 for downloaded index filenames in order to be compatible on windows FS
  • add tool entry with version in installed.json
  • fix extracting renaming using standard path

this has to be retested on all OSes

@rsora rsora requested a review from matteosuppo April 19, 2019 16:49
@matteosuppo matteosuppo changed the title Fix windows v2 download tool Fix windows v2 download tool [EDITOR-140] Apr 23, 2019
@matteosuppo
Copy link
Contributor

Should fix #358

@matteosuppo matteosuppo merged commit cb014fd into devel Apr 23, 2019
@matteosuppo matteosuppo deleted the fix-windows-v2-download-tool branch April 23, 2019 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants