#1525 Removed the real_name of the libraries
#1528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been removed from the gRPC API: arduino/arduino-cli#1890 This PR switches from `real_name` to `name` in the UI, as the `name` is the canonical form provided by the CLI. Closes #1525 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
francescospissu
approved these changes
Oct 5, 2022
Contributor
francescospissu
left a comment
There was a problem hiding this comment.
It works well for me. Using getName() instead of getRealName() and grouping by name the examples it behaves as expected👍
per1234
approved these changes
Oct 5, 2022
Collaborator
per1234
left a comment
There was a problem hiding this comment.
It is working perfectly for me. Thanks Akos!
Contributor
Author
|
Thank you for the quick review ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Align gRPC APIs with the most recent Arduino CLI. The
Library#real_namehas been removed from the gRPC API: arduino/arduino-cli#1890This PR switches from
real_nametonamein the UI, as thenameis the canonical form provided by the CLI.Change description
Other information
How to verify:
SparkFun color lcdin the search<input>, (expected a single result:SparkFun Color LCD Shield)UNINSTALL,SparkFun Color LCD Shield@1.0.1,File>Examples> verify that you seeSparkFun Color LCD Shieldas the grouping menu item. Like this:Closes #1525
Reviewer checklist