feat(agent/agentcontainers): add Exec method to devcontainers CLI #18244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 5, 2025
Merged
dda97d9 to
2984d4e
Compare
d49f84e to
011a8aa
Compare
ae52380 to
5cf4ae7
Compare
011a8aa to
63f93bc
Compare
5cf4ae7 to
2dc395d
Compare
63f93bc to
0deaab8
Compare
2dc395d to
ea0125d
Compare
0deaab8 to
8796ba3
Compare
johnstcn
reviewed
Jun 6, 2025
Comment on lines
45
to
84
| // WithContainerID sets the container ID to target a specific container. | ||
| // Can only be used with the Exec command. | ||
| func WithContainerID(id string) DevcontainerCLIOptions { | ||
| return func(o *devcontainerCLIUpConfig) { | ||
| if o.command != "exec" { | ||
| panic("developer error: WithContainerID can only be used with the Exec command") | ||
| } | ||
| o.args = append(o.args, "--container-id", id) | ||
| } | ||
| } | ||
|
|
||
| // WithRemoteEnv sets environment variables for the Exec command. | ||
| // Can only be used with the Exec command. | ||
| func WithRemoteEnv(env ...string) DevcontainerCLIOptions { | ||
| return func(o *devcontainerCLIUpConfig) { | ||
| if o.command != "exec" { | ||
| panic("developer error: WithRemoteEnv can only be used with the Exec command") | ||
| } | ||
| for _, e := range env { | ||
| o.args = append(o.args, "--remote-env", e) | ||
| } | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Given that these two options can only be used with devcontainer exec, I think it makes more sense to keep them as a different type. I like the idea of having the uniform signature of ...DevcontainerCLIOptions but this is offset by potential run-time errors instead of compile-time errors.
Member
Author
There was a problem hiding this comment.
Yeah, agreed, I'll change it.
Base automatically changed from
mafredri/feat-agent-devcontainer-injection-2
to
main
June 6, 2025 10:33
This change adds Exec to the devcontainer CLI. Updates coder/internal#621
8796ba3 to
adbfd45
Compare
DanielleMaywood
approved these changes
Jun 6, 2025
johnstcn
approved these changes
Jun 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds Exec to the devcontainer CLI.
Updates coder/internal#621