feat: add coder_workspace_port_forward MCP tool #19863
Conversation
| // setupWorkspaceForAgent creates a workspace setup exactly like main SSH tests | ||
| // nolint:gocritic // This is in a test package and does not end up in the build | ||
| func setupWorkspaceForAgent(t *testing.T) (*codersdk.Client, database.WorkspaceTable, string) { | ||
| func setupWorkspaceForAgent(t *testing.T, opts *coderdtest.Options) (*codersdk.Client, database.WorkspaceTable, string) { |
There was a problem hiding this comment.
This is a super minor nit: We could have left this function and its signature unchanged, added a new setupWorkspaceForAgentWithOptions, and made this function call the new one internally with nil options.
That way, all other code remains untouched, resulting in an even smaller diff.
There was a problem hiding this comment.
I had the same thought but, I felt like I was trading diff size for dev experience. Because this is basically is a convenience wrapper around coderdtest.NewWithDatabase, having a similar signature makes it consistent and predictable, and easier to add options in the future (no need to discover that a WithOptions version exists).
I do wish I could merge this in a separate commit though, without having to open a second PR.
f1e7942 to
02c889e
Compare
Closes coder/internal#784