chore: add more rules to ensure logs consistency #8104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Jun 21, 2023
Member
mafredri
left a comment
There was a problem hiding this comment.
Looks good! I would still suggest changing all instances of can't [thing] to either unable to [thing], [thing] failed or similar.
(PS. Odd, I could've sworn I submitted this PR review yesterday already ¯\_(ツ)_/¯.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6726
This PR extends linting rules to cover
<foo>.logger.<method>cases. Apparently, current rules miss lines where the logger was a field of a structure.