feat: add confliction with subdomain
#469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielleMaywood
approved these changes
Nov 24, 2025
mtojek
reviewed
Nov 24, 2025
jakehwll
commented
Nov 24, 2025
Member
|
@jakehwll Is it ready to merge, or are you still tinkering? |
Contributor
Author
Need to remove the other duplicate test case! Will resolve in a few hours, happy otherwise |
matifali
reviewed
Nov 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #343
This pull-request ensures that when we have a
commandobject key that it will conflict if we attempt to usesubdomain = truespecified. This was previously an error back in July 2023, however it seems that we no longer actually throw a 500 if this doesn't exist, rather we simply ignore thesubdomainkey.For better overall handling we simply conflict against this now.