Skip to content

Allow empty output from header command #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
code-asher merged 1 commit into from
Jun 25, 2024
Merged

Allow empty output from header command #308

code-asher merged 1 commit into from
Jun 25, 2024

Conversation

@davo-canva
Copy link
Contributor

@davo-canva davo-canva commented Jun 25, 2024

Allow no output from the header command, for parity with the Coder CLI, similarly to the JetBrains plugin in coder/jetbrains-coder#404

@matifali matifali requested a review from code-asher June 25, 2024 06:38
code-asher
code-asher approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@code-asher code-asher merged commit 6363dd4 into coder:main Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davo-canva @code-asher