Switch to System.ComponentModel.TypeConverter #1725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [Xaml.ProvideCompiled("Microsoft.Maui.Controls.XamlC.BindablePropertyConverter")] | ||
| [Xaml.TypeConversion(typeof(BindableProperty))] | ||
| public sealed class BindablePropertyConverter : TypeConverter, IExtendedTypeConverter | ||
| public sealed class BindablePropertyConverter : StringTypeConverterBase, IExtendedTypeConverter |
Contributor
There was a problem hiding this comment.
as ITypeDescriptorContext is a IServiceProvider, we probably could get rid of IExtendedTypeConverter (that adds a IServiceProvider parameter)
Forms used to define its own TypeConverter following the same convention of converting to/from an invariant string since netstandard1.x did not have the `System.ComponentModel.TypeConverter`. This moves to using the standardized type which is expected more throughout the ecosystem.
Get it from graphics now
b91792c to
b975eb0
Compare
Member
Author
|
Added converters into Maui Graphics: dotnet/Microsoft.Maui.Graphics#126 |
This was moved back to Controls some time ago and never cleaned up here.
mattleibow
approved these changes
Jul 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forms used to define its own TypeConverter following the same convention of converting to/from an invariant string since netstandard1.x did not have the
System.ComponentModel.TypeConverter.This moves to using the standardized type which is expected more throughout the ecosystem.
TODO:
PR Checklist