Only prompt for failurePolicies if they are new. #3164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes firebase/firebase-functions#798 We can now conditionally list functions earlier in the deploy pipeline if there are any functions with a failure policy in the current set of functions to deploy. Silence the prompt if all functions with failure policies already had failure policies. Also modifies prepare.ts to avoid redndantly calling listallfunctions later.
joehan
reviewed
Feb 23, 2021
Member
joehan
left a comment
There was a problem hiding this comment.
Mostly LGTM, but I'd prefer to not repeat API calls unnecessarily
src/deploy/functions/prompts.ts
Outdated
|
|
||
| // N.B. Because context is an any, we need to store it in a temporary. This | ||
| // lets us do a 'for of' loop later with typeinfo. | ||
| const existingFunctions = await gcp.cloudfunctions.listAllFunctions(context.projectId); |
Member
There was a problem hiding this comment.
We already make this call once during the deployment process, at the start of 'deploy.ts' - WDYT about reordering things such that we only need to do this once?
Member
Author
There was a problem hiding this comment.
Guarded both cases with existing || await listAllFunctions. In reality, Context should have context.allFunctions() which is a caching implementation and easily mocked. ¯_(ツ)_/¯
1. Cache the lookups to listAllFunctions
2. When passing a mock to listAllFunctions stub, use the API location
for failurePolicy: {}
3. Add release notes
joehan
approved these changes
Mar 2, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
* Only prompt for failurePolicies if they are new. Fixes firebase/firebase-functions#798 We can now conditionally list functions earlier in the deploy pipeline if there are any functions with a failure policy in the current set of functions to deploy. Silence the prompt if all functions with failure policies already had failure policies. Also modifies prepare.ts to avoid redundantly calling listallfunctions later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes firebase/firebase-functions#798
We can now conditionally list functions earlier in the deploy pipeline
if there are any functions with a failure policy in the current
set of functions to deploy. Silence the prompt if all functions with
failure policies already had failure policies.
Also modifies prepare.ts to avoid redundantly calling listAllFunctions
later.
Scenarios Tested
Sample Commands
firebase deploy [--only functions]Notes
Tests previously checked for throwing instead of rejecting, which worked if and only if the throw happened before yielding the thread. This broke all tests that ran into the new check for existing functions.