Skip to content

Functions #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tunggnu merged 5 commits into from
Jul 15, 2024
Merged

Functions #222

tunggnu merged 5 commits into from
Jul 15, 2024

Conversation

@hoangnv170752
Copy link
Contributor

@hoangnv170752 hoangnv170752 commented Jul 13, 2024

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team July 13, 2024 07:10
@CLAassistant
Copy link

CLAassistant commented Jul 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Jul 13, 2024
Open
@hoangnv170752
Copy link
Contributor Author

hoangnv170752 commented Jul 13, 2024

@tunggnu & @henryonsoftware xin phép ping các anh về phần review và merge ạ

tunggnu
tunggnu requested changes Jul 13, 2024
View reviewed changes
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 13, 2024

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@tunggnu
Copy link
Contributor

tunggnu commented Jul 13, 2024

@hoangnv170752 bạn cần ký thỏa thuận tác quyền ở link này #222 (comment)

hoangnv170752
hoangnv170752 commented Jul 13, 2024
View reviewed changes
Copy link
Contributor Author

@hoangnv170752 hoangnv170752 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Em có đẩy 1 commit mới sửa các lỗi dịch ạ

@tunggnu tunggnu self-assigned this Jul 13, 2024
@hoangnv170752 hoangnv170752 requested a review from tunggnu July 13, 2024 13:24
tunggnu
tunggnu requested changes Jul 13, 2024
View reviewed changes
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 13, 2024

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@hoangnv170752 hoangnv170752 requested a review from tunggnu July 14, 2024 00:51
tunggnu
tunggnu requested changes Jul 14, 2024
View reviewed changes
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 14, 2024

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@tunggnu
Copy link
Contributor

tunggnu commented Jul 14, 2024

@hoangnv170752 bạn xem lại 3 bình luận của mình ở trên để sửa nội dung tương ứng, sửa xong cái nào bạn bấm Resolve conversation để đóng bình luận đó lại.

@hoangnv170752 hoangnv170752 requested a review from tunggnu July 15, 2024 02:01
@tunggnu
Copy link
Contributor

tunggnu commented Jul 15, 2024

@hoangnv170752 còn bình luận này bạn chưa xử lý #222 (comment)

@hoangnv170752
Copy link
Contributor Author

hoangnv170752 commented Jul 15, 2024

Em đã hoàn thiện ạ @tunggnu

@tunggnu tunggnu merged commit 3c4c432 into javascript-tutorial:master Jul 15, 2024
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 15, 2024

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tunggnu tunggnu tunggnu approved these changes

Assignees

@tunggnu tunggnu

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoangnv170752 @CLAassistant @javascript-translate-bot @tunggnu