Skip to content

Conversation

@fixiabis
Copy link
Contributor

Target chapter

9-regular-expressions/01-regexp-introduction

Modified files

File name Change(reason)
article.md 翻譯繁體中文

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lenchen1112 lenchen1112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts :)

Copy link
Contributor

@lenchen1112 lenchen1112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@fixiabis
Copy link
Contributor Author

/done

Copy link
Contributor

@lenchen1112 lenchen1112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @javascript-tutorial/translate-zh-hant anyone has concerns?

Copy link
Contributor

@ArvinH ArvinH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fixiabis
Copy link
Contributor Author

Just signed.

@lenchen1112 lenchen1112 merged commit 075e078 into javascript-tutorial:master Apr 20, 2021
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants