Skip to content

Manuals and specifications #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tom76kimo merged 1 commit into from
Sep 6, 2019
Merged

Manuals and specifications #24

tom76kimo merged 1 commit into from
Sep 6, 2019

Conversation

@tom76kimo
Copy link
Contributor

@tom76kimo tom76kimo commented Aug 28, 2019

Target chapter

1-js/01-getting-started/2-manuals-specifications

Modified files

File name Change（reason）
article.md 翻譯繁體中文

@javascript-translate-bot javascript-translate-bot requested a review from a team August 28, 2019 10:19
@iliakan iliakan mentioned this pull request Aug 28, 2019
Open
@CLAassistant
Copy link

CLAassistant commented Aug 28, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

lenchen1112
lenchen1112 requested changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@lenchen1112 lenchen1112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting and translate suggestions

@javascript-translate-bot
Copy link

javascript-translate-bot commented Aug 28, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@lenchen1112
Copy link
Contributor

lenchen1112 commented Aug 28, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

竟然有這東西 lol

ArvinH
ArvinH reviewed Aug 28, 2019
View reviewed changes
1-js/01-getting-started/2-manuals-specifications/article.md Outdated
- **MDN (Mozilla) JavaScript Reference** 是一個包含了範例以及其他資訊的手冊，很適合拿來獲取個別函式或是方法的深入資訊。

- **MDN (Mozilla) JavaScript Reference** is a manual with examples and other information. It's great to get in-depth information about individual language functions, methods etc.
你可以在這裡找到 <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference>.
Copy link
Contributor

@ArvinH ArvinH Aug 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

根據上下文，或許可以改成這樣？

Suggested change
你可以在這裡找到 <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference>.
你可以從這裡尋找資訊 <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference>.

Copy link
Contributor Author

@tom76kimo tom76kimo Aug 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@ArvinH
Copy link
Contributor

ArvinH commented Aug 28, 2019

@tom76kimo 你的 CLA 發生什麼事～

@tom76kimo
Copy link
Contributor Author

tom76kimo commented Aug 28, 2019

第一個 commit 用錯帳號的樣子~

@lenchen1112
Copy link
Contributor

lenchen1112 commented Sep 2, 2019

@tom76kimo 是有沒要改～

lenchen1112
lenchen1112 requested changes Sep 3, 2019
View reviewed changes
@javascript-translate-bot
Copy link

javascript-translate-bot commented Sep 3, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

lenchen1112
lenchen1112 requested changes Sep 3, 2019
View reviewed changes
@javascript-translate-bot
Copy link

javascript-translate-bot commented Sep 3, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@lenchen1112
Copy link
Contributor

lenchen1112 commented Sep 5, 2019

記得 rebase master，要先 sync origin 的 commit 喔，不然 suggestion 的會沒打上去

@tom76kimo @lenchen1112 @ArvinH
Add partial translation
68b7c45 
Finish translation

Apply suggestions from code review

Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
Co-Authored-By: ArvinH <arvin0731@gmail.com>
@tom76kimo
Copy link
Contributor Author

tom76kimo commented Sep 5, 2019

Updated

lenchen1112
lenchen1112 approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@lenchen1112 lenchen1112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🚀

@tom76kimo tom76kimo merged commit 6ded928 into javascript-tutorial:master Sep 6, 2019
@javascript-translate-bot
Copy link

javascript-translate-bot commented Sep 6, 2019

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@tom76kimo tom76kimo deleted the 1.1.2 branch September 6, 2019 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArvinH ArvinH ArvinH approved these changes

@lenchen1112 lenchen1112 lenchen1112 approved these changes

Assignees

@ArvinH ArvinH

@kaddopur kaddopur

@tom76kimo tom76kimo

@lenchen1112 lenchen1112

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tom76kimo @CLAassistant @javascript-translate-bot @lenchen1112 @ArvinH @kaddopur