Skip to content

Interaction: alert, prompt, confirm #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lenchen1112 merged 4 commits into from
Aug 30, 2019
Merged

Interaction: alert, prompt, confirm #25

lenchen1112 merged 4 commits into from
Aug 30, 2019

Conversation

@lenchen1112
Copy link
Contributor

@lenchen1112 lenchen1112 commented Aug 29, 2019

Target chapter

1-js/02-first-steps/09-alert-prompt-confirm

Modified files

File name Change（reason）
article.md 翻譯繁體中文
1-simple-page/* 翻譯繁體中文

@lenchen1112 lenchen1112 requested a review from a team August 29, 2019 03:01
@lenchen1112 lenchen1112 self-assigned this Aug 29, 2019
@iliakan iliakan mentioned this pull request Aug 29, 2019
Open
@ArvinH ArvinH self-requested a review August 29, 2019 03:42
ArvinH
ArvinH reviewed Aug 29, 2019
View reviewed changes
lenchen1112 and others added 3 commits August 30, 2019 09:44
@lenchen1112 @ArvinH
doc: modify texting of `1-js/02-first-steps/09-alert-prompt-confirm/a…
16ca276 
…rticle.md`

Co-Authored-By: ArvinH <arvin0731@gmail.com>
@lenchen1112 @ArvinH
docs: modify texting of `1-js/02-first-steps/09-alert-prompt-confirm/…
b49a4e3 
…article.md`

Co-Authored-By: ArvinH <arvin0731@gmail.com>
@lenchen1112 @ArvinH
docs: modify text of `1-js/02-first-steps/09-alert-prompt-confirm/art…
7e9d2ac 
…icle.md`

Co-Authored-By: ArvinH <arvin0731@gmail.com>
ArvinH
ArvinH approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@ArvinH ArvinH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆 🇹🇼

@lenchen1112 lenchen1112 merged commit dc6a7fb into javascript-tutorial:master Aug 30, 2019
@javascript-translate-bot
Copy link

javascript-translate-bot commented Aug 30, 2019

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArvinH ArvinH ArvinH approved these changes

@kaddopur kaddopur kaddopur approved these changes

Assignees

@lenchen1112 lenchen1112

Labels

needs +1 review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lenchen1112 @javascript-translate-bot @ArvinH @kaddopur