Skip to content

Comparisons #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ArvinH merged 38 commits into from
Sep 2, 2019
Merged

Comparisons #32

ArvinH merged 38 commits into from
Sep 2, 2019

Conversation

@ArvinH
Copy link
Contributor

@ArvinH ArvinH commented Aug 31, 2019

Target chapter

1-js/02-first-steps/08-comparison

Modified files

File name Change（reason）
article.md 翻譯繁體中文
1-comparison-questions/solution.md 翻譯繁體中文
1-comparison-questions/solution.md 翻譯繁體中文

@javascript-translate-bot javascript-translate-bot requested a review from a team August 31, 2019 12:49
@iliakan iliakan mentioned this pull request Aug 31, 2019
Open
lenchen1112
lenchen1112 requested changes Sep 1, 2019
View reviewed changes
@javascript-translate-bot
Copy link

javascript-translate-bot commented Sep 1, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

ArvinH and others added 10 commits September 1, 2019 12:41
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
9bea300 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
627be4c 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
7cef081 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
66fecec 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
cbf8b08 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
ae19a1b 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
d859301 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
4ebc915 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
640c590 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
1f4b3df 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH ArvinH requested a review from lenchen1112 September 1, 2019 03:45
ArvinH and others added 7 commits September 1, 2019 16:17
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
de53f4e 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
3ed0cf6 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
3d208e0 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
20bd72e 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
da8f9ec 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
7862ba3 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
3e74a5d 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
ArvinH and others added 18 commits September 1, 2019 16:19
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
9dd8cad 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
d92f6de 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
a2083b4 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
8f5c53e 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
7150940 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
1de64d4 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
38e69d2 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
6d58082 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
a3924d9 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
8fbe828 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
6311e57 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
3a817d3 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
edd02af 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
d14c8f1 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
495d5d8 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
b75aed1 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
036bbc3 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH @lenchen1112
Update 1-js/02-first-steps/08-comparison/article.md
c8a3abd 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
kaddopur
kaddopur approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@kaddopur kaddopur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ArvinH ArvinH merged commit da12e44 into javascript-tutorial:master Sep 2, 2019
@javascript-translate-bot
Copy link

javascript-translate-bot commented Sep 2, 2019

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@ArvinH ArvinH deleted the 1-02-08 branch September 2, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaddopur kaddopur kaddopur approved these changes

@lenchen1112 lenchen1112 lenchen1112 approved these changes

Assignees

@ArvinH ArvinH

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArvinH @javascript-translate-bot @kaddopur @lenchen1112