Skip to content

Symbol type #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ArvinH merged 10 commits into from
Nov 4, 2019
Merged

Symbol type #66

ArvinH merged 10 commits into from
Nov 4, 2019

Conversation

@ArvinH
Copy link
Contributor

@ArvinH ArvinH commented Oct 19, 2019

Target chapter

1-js/04-object-basics/03-symbol

Modified files

File name Change（reason）
article.md 翻譯繁體中文

@javascript-translate-bot javascript-translate-bot requested a review from a team October 19, 2019 08:11
@iliakan iliakan mentioned this pull request Oct 19, 2019
Open
@lenchen1112
Copy link
Contributor

lenchen1112 commented Oct 19, 2019

我之前 Symbol 都有翻 符號，資料的 type 都是翻 類型，看要不要統一一下

lenchen1112
lenchen1112 requested changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@lenchen1112 lenchen1112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

裡面有些 他 跟 它 混用的情況看要不要也統一一下～

@javascript-translate-bot
Copy link

javascript-translate-bot commented Oct 20, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ArvinH
Copy link
Contributor Author

ArvinH commented Oct 20, 2019

裡面有些 他 跟 它 混用的情況看要不要也統一一下～

我再檢查看看，我是想都用 "它"，可能有漏掉

ArvinH and others added 2 commits October 21, 2019 12:18
@ArvinH
fix: 他 -> 它
453661a
@ArvinH @lenchen1112
Apply suggestions from code review
3c5a42f 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
ArvinH
ArvinH commented Oct 21, 2019
View reviewed changes
@ArvinH ArvinH requested review from a team and lenchen1112 October 21, 2019 03:36
lenchen1112
lenchen1112 reviewed Oct 21, 2019
View reviewed changes
lenchen1112
lenchen1112 approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@lenchen1112 lenchen1112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🚀

lenchen1112
lenchen1112 requested changes Oct 21, 2019
View reviewed changes
@javascript-translate-bot
Copy link

javascript-translate-bot commented Oct 21, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ArvinH @lenchen1112
Update 1-js/04-object-basics/03-symbol/article.md
e7d7d7e 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@ArvinH ArvinH merged commit 76544a9 into javascript-tutorial:master Nov 4, 2019
@javascript-translate-bot
Copy link

javascript-translate-bot commented Nov 4, 2019

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@ArvinH ArvinH deleted the 1-04-03-v2 branch November 4, 2019 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenchen1112 lenchen1112 lenchen1112 approved these changes

+1 more reviewer

@tom76kimo tom76kimo tom76kimo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ArvinH ArvinH

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArvinH @lenchen1112 @javascript-translate-bot @tom76kimo