Skip to content

Conversation

@grosser
Copy link
Contributor

@grosser grosser commented Oct 25, 2022

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

atm aws fails after 3 retries since we use the default config, which leads to backoffs, which leads to clusters not scaling as requested

Does this PR introduce a user-facing change?

- support AWS_MAX_ATTEMPTS to configure max retries

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 25, 2022
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and x13n October 25, 2022 21:07
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 25, 2022
@gjtempleton gjtempleton added the area/provider/aws Issues or PRs related to aws provider label Dec 11, 2022
@gjtempleton
Copy link
Member

/assign @gjtempleton

Hey there @grosser, thanks for the PR!

Apologies, hadn't noticed this one before so there's now a merge conflict post the merging of #5120 to address as well as the comment on variable naming styling from the PR check. If you get those addressed happy to get this merged as agreed on this looking useful.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2022
@grosser
Copy link
Contributor Author

grosser commented Dec 12, 2022

rebased, lmk if that looks good :)

@gjtempleton
Copy link
Member

One more small request, can we add a brief entry to the AWS cloudprovider readme to explain how to make use of this?

Other than that, this LGTM.

@grosser
Copy link
Contributor Author

grosser commented Dec 26, 2022

done

@grosser
Copy link
Contributor Author

grosser commented Dec 26, 2022

@gjtempleton

@gjtempleton
Copy link
Member

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, grosser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 10b24ba into kubernetes:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants