-
Notifications
You must be signed in to change notification settings - Fork 4.3k
aws: allow setting max retries from AWS_MAX_ATTEMPTS env var #5270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/assign @gjtempleton Hey there @grosser, thanks for the PR! Apologies, hadn't noticed this one before so there's now a merge conflict post the merging of #5120 to address as well as the comment on variable naming styling from the PR check. If you get those addressed happy to get this merged as agreed on this looking useful. |
|
rebased, lmk if that looks good :) |
|
One more small request, can we add a brief entry to the AWS cloudprovider readme to explain how to make use of this? Other than that, this LGTM. |
|
done |
|
Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, grosser The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
atm aws fails after 3 retries since we use the default config, which leads to backoffs, which leads to clusters not scaling as requested
Does this PR introduce a user-facing change?