Cap logs logged by HintingSimulator. #5380
Conversation
| break | ||
| } | ||
| } | ||
| klogx.V(4).Over(loggingQuota).Infof("There were also %v other logs that were capped.", -loggingQuota.Left()) |
There was a problem hiding this comment.
nit: Maybe clarify what kind of logs, or include some other more precise info (e.g. prefix with the name of the function). Log lines from other goroutines could get inserted in between and then it'd be hard to know what this line refers to.
|
/assign @towca Feel free to unhold if you disagree with the nit. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kisieland, towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To avoid excesive logging of the HintingSimulator we should use klogx to cap the number of logged lines depending on the verbosity level.
e08cdf4 to
b6fa1f5
Compare
|
@towca makes sense, added clarification. PTAL |
|
/lgtm |
|
/unhold |
To avoid excesive logging of the HintingSimulator we should use klogx to cap the number of logged lines depending on the verbosity level.
Which component this PR applies to?
Cluster Autoscaler
/kind bug
What this PR does / why we need it:
Uses klogx to cap the number of log lines logged by the Hinting Simulator.
This avoids excessive logging.
Special notes for your reviewer:
Does this PR introduce a user-facing change?