implement time limiter for binpacking #6556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52dd86f to
ea2b801
Compare
84767bd to
51d1c2f
Compare
x13n
reviewed
Jun 12, 2024
Member
x13n
left a comment
There was a problem hiding this comment.
Thanks! Looks good overall, just some minor comments.
51d1c2f to
0728d15
Compare
x13n
reviewed
Jun 17, 2024
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damikag, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR implements two new
BinpackingLimiterTimeLimitterwill limit total time spent on bin packing.With this new limiter bin packing will cut short after exceeding the
maxBinpackingDuration.The
maxBinpackingDurationis set using--max-binpacking-time.CombinedLimiterwhich is the other limiter combines multiple limiters and limit bin packing when at least one limiter meets a stop condition.Does this PR introduce a user-facing change?