Skip to content

Conversation

@pritesh-shrivastava
Copy link
Contributor

@pritesh-shrivastava pritesh-shrivastava commented Aug 13, 2020

I've added %matplotlib inline command to the Jupyter notebook for SVD tutorial. Without this command, the given imageimg doesn't show in a Jupyter notebook until executing the cell twice.
Besides, I've also added the code output for the SVD notebook as it makes the tutorial easier to follow !!
I've also added .ipynb_checkpoints into the .gitignore file under the header # Editor temporary/working/backup files #.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@melissawm
Copy link
Member

Hello, @pritesh-shrivastava ! Thanks for taking a look.

I agree that we should add %matplotlib inline , that should make the notebook more complete. For the outputs, it is our understanding that they should not be kept in the notebooks in this repo, as the notebooks should be executed by users as necessary (either locally, by cloning the repo, or using binder - see #17).

Note that there's a rendered version of this tutorial at https://numpy.org/devdocs/user/tutorial-svd.html

Let me know if you have any questions, and welcome!

@pritesh-shrivastava
Copy link
Contributor Author

Thanks @melissawm for the feedback. I've removed the notebook output in the SVD tutorial.
I've still kept matplotlib inline command in the svd notebook & ipynb_checkpoints in the gitignore file.
Let me know if you want me to make any other changes to this PR.

Thanks again !

@melissawm
Copy link
Member

This looks good to me, thanks @pritesh-shrivastava !

@melissawm melissawm merged commit af388e5 into numpy:master Aug 20, 2020
@pritesh-shrivastava pritesh-shrivastava deleted the update-svd-tutorial branch August 20, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants