Skip to content

Conversation

@laxmikantbpandhare
Copy link
Member

This will fix the bug from Bugzilla - 2099580

I created issue #94 this also get fixed after the merge of this PR.

Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laxmikantbpandhare Could we also update the sample in the testdata/ directory so that our sample is up to date with our tutorial?

@laxmikantbpandhare
Copy link
Member Author

Sure @everettraven thanks for pointing out

Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

holding until PR title is updated to match format of Bug xxxxxx: summary as mentioned by @jmrodri offline
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2022
@laxmikantbpandhare laxmikantbpandhare changed the title big fix for deletion Custom resource Bug [2099580] - Deployment is not deleted when CR is deleted in Java operator Jul 22, 2022
@laxmikantbpandhare laxmikantbpandhare changed the title Bug [2099580] - Deployment is not deleted when CR is deleted in Java operator Bug [2099580] - This fix will take care of deletion part of CR in java Operator. Jul 22, 2022
@everettraven
Copy link
Collaborator

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2022
@laxmikantbpandhare laxmikantbpandhare merged commit e4aed38 into operator-framework:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug [2099580] - Deployment is not deleted when CR is deleted in Java operator

2 participants