Skip to content

Add type specifying support for classes extending Assert #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ondrejmirtes merged 1 commit into from
Oct 6, 2021
Merged

Add type specifying support for classes extending Assert #106

ondrejmirtes merged 1 commit into from
Oct 6, 2021

Conversation

@nreynis
Copy link

@nreynis nreynis commented Oct 1, 2021

Fixes #103

The actual assert* methods are implemented in PHPUnit\Framework\Assert not in PHPUnit\Framework\TestCase

ondrejmirtes
ondrejmirtes requested changes Oct 5, 2021
View reviewed changes
@nreynis nreynis force-pushed the add-support-for-extending-assert branch from 0834e8f to 72af8b0 Compare October 5, 2021 18:49
@nreynis nreynis requested a review from ondrejmirtes October 5, 2021 18:54
@ondrejmirtes ondrejmirtes merged commit 54ed35b into phpstan:master Oct 6, 2021
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Oct 6, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes Awaiting requested review from ondrejmirtes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AssertMethodTypeSpecifyingExtension does not target the correct class

2 participants

@nreynis @ondrejmirtes