Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 795e94c
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 24ee495
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Dec 11, 2025

  1. Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION. 

    Prior to v15, GUC settings supplied in the CONNECTION clause of
CREATE SUBSCRIPTION were correctly passed through to
the publisher's walsender. For example:

        CREATE SUBSCRIPTION mysub
            CONNECTION 'options=''-c wal_sender_timeout=1000'''
            PUBLICATION ...

would cause wal_sender_timeout to take effect on the publisher's walsender.

However, commit f3d4019 changed the way logical replication
connections are established, forcing the publisher's relevant
GUC settings (datestyle, intervalstyle, extra_float_digits) to
override those provided in the CONNECTION string. As a result,
from v15 through v18, GUC settings in the CONNECTION string were
always ignored.

This regression prevented per-connection tuning of logical replication.
For example, using a shorter timeout for walsender connecting
to a nearby subscriber and a longer one for walsender connecting
to a remote subscriber.

This commit restores the intended behavior by ensuring that
GUC settings in the CONNECTION string are again passed through
and applied by the walsender, allowing per-connection configuration.

Backpatch to v15, where the regression was introduced.

Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Chao Li <lic@highgo.com>
Discussion: https://postgr.es/m/CAHGQGwGYV+-abbKwdrM2UHUe-JYOFWmsrs6=QicyJO-j+-Widw@mail.gmail.com
Backpatch-through: 15
    @MasaoFujii
    MasaoFujii authored and Commitfest Bot committed Dec 11, 2025
    Configuration menu
    Copy the full SHA
    5453fcf View commit details
    Browse the repository at this point in the history

  2. Add TAP test for GUC settings passed via CONNECTION in logical replic… 

    …ation.

This commit adds a TAP test to verify that GUC settings provided in
the CONNECTION string of CREATE/ALTER SUBSCRIPTION are correctly
passed through to and applied by the publisher's walsender.
    @MasaoFujii
    MasaoFujii authored and Commitfest Bot committed Dec 11, 2025
    Configuration menu
    Copy the full SHA
    0d2149e View commit details
    Browse the repository at this point in the history

  3. [CF 6239] v4 - Allow GUC settings in CREATE SUBSCRIPTION CONNECTION t… 

    …o take effect on publisher's walsender

This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/6239

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CAHGQGwGxSVPia+ZtJxyqWTdP_-YG_YPb=CMrZpC7fTjknARX=A@mail.gmail.com
Author(s): Fujii Masao
    Commitfest Bot committed Dec 11, 2025
    Configuration menu
    Copy the full SHA
    24ee495 View commit details
    Browse the repository at this point in the history
Loading