Skip to content

Conversation

@YasunariZHashimoto
Copy link
Contributor

@YasunariZHashimoto YasunariZHashimoto commented Nov 25, 2019

If you're adding a project to the Python 3 statement, please ensure you have:

  • Discussed dropping Python 2 support with all maintainers
  • Discussed signing the statement with all maintainers
  • Added a suitable logo if the project has one
    • Approximately square logos generally fit better than banners
    • Compressed the logo to save bandwidth (run scripts/squash-images.sh on it)
      • Add a link to the logo instead of uploading it.
  • Checked the Netlify preview made from the pull request

I added a link to the logo instead of uploading it. I am one of the main maintainers of the Neural Network Libraries. You can see my account the following https://github.com/sony/nnabla/graphs/contributors .

- [![](assets/scikit-image.png)Scikit Image](http://scikit-image.org/) <!-- url:https://github.com/scikit-image/scikit-image sg:3069 -->
- [![](assets/sphinx-doc.png)Sphinx](https://www.sphinx-doc.org/) <!-- url:https://github.com/sphinx-doc/sphinx sg:2681 -->
- [![](assets/geopy.png)geopy](https://geopy.readthedocs.io/) <!-- url:https://github.com/geopy/geopy sg:2476 -->
- [![](https://nnabla.org/logos/logo3.png)Neural Network Libraries](https://nnabla.org/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put an HTML comment with the Github URL, like the other lines? There's a script that gets the updated star counts using these and resorts the list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, got it. Thank you for the feedback.

Copy link
Contributor Author

@YasunariZHashimoto YasunariZHashimoto Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the GitHub URL. Please confirm the change thanks.

@takluyver
Copy link
Member

This LGTM apart from that comment; thanks.

@takluyver takluyver merged commit bdc66a6 into python3statement:master Dec 2, 2019
@takluyver
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants