Use callable classes for custom Monolog processors #10125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jaikdean I've just checked Monolog and you are totally right! Let's make this change because it's consistent and simplifies things a lot. Thanks for helping us improve Symfony Docs and congrats on your first contribution to this repository! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 27, 2018
…dean) This PR was merged into the 2.8 branch. Discussion ---------- Use callable classes for custom Monolog processors The built-in Monolog processors all use callable classes with an `__invoke()` method, whereas the Symfony documentation uses a `processRecord()` method. Using `__invoke()` provides consistency with the standard processors and also removes the need to specify the method name in the service configuration. Commits ------- 6f1a0f3 Use callable classes for custom Monolog processors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built-in Monolog processors all use callable classes with an
__invoke()method, whereas the Symfony documentation uses aprocessRecord()method. Using__invoke()provides consistency with the standard processors and also removes the need to specify the method name in the service configuration.