Update doctrine.rst #9141
Closed
Update doctrine.rst #9141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jan 28, 2018
reference/configuration/doctrine.rst
Outdated
| collate: ~ | ||
| path: ~ | ||
| memory: ~ | ||
Member
There was a problem hiding this comment.
just a minor comment: this blank line should be removed (but we can do that while merging)
xabbuh
approved these changes
Jan 28, 2018
Member
javiereguiluz
left a comment
There was a problem hiding this comment.
To be honest, this looks like a bug or a poor DX in DoctrineBundle. Table charset/collate should be the same as the one configured in the database ... unless you configure the table options explicitly. But maybe I'm missing something here.
Member
|
For the records, there is a related issues in the DoctrineBundle repo (see doctrine/DoctrineBundle#766). |
my doctrine.yml had a ```charset: utf8mb4``` but my schema update generated tables with utf8. Seems like there is a separate configuration directive for the tables and this is not inherited from the database
Member
|
@tvlooy thanks for this nice little tip. I hope DoctrineBundle fixes it in the future and this is no longer needed. By the way, we merged this in 2.7 branch. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 29, 2018
This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes #9141). Discussion ---------- Update doctrine.rst my doctrine.yml had a ```charset: utf8mb4``` but my schema update generated tables with utf8. Seems like there is a separate configuration directive for the tables and this is not inherited from the database Commits ------- 81f9051 Update doctrine.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my doctrine.yml had a
charset: utf8mb4but my schema update generated tables with utf8. Seems like there is a separate configuration directive for the tables and this is not inherited from the database