Clarify accName for input type=image #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds clarifying language for the alt and title steps. updates the localized text string step to better match the updated input type=button/reset/submit, and note the fact that this element is considered a 'submit button' - linking to that portion of the HTML spec and noting that different browsers may provide a different default string (e.g., chrome does 'submit' while firefox does 'submit query')
MelSumner
approved these changes
Jul 27, 2023
MelSumner
left a comment
There was a problem hiding this comment.
Suggestion, non-blocker: I think "an empty string" reads a little better than "the empty string". 👍
| </li> | ||
| <li>Otherwise use `alt` attribute.</li> | ||
| <!-- NOTE: use of valid attribute is invalid on input type=image, but it DOES contribute to the name if used --> | ||
| <li>Otherwise use `alt` attribute if present and its value is not the empty string.</li> |
There was a problem hiding this comment.
Suggested change
| <li>Otherwise use `alt` attribute if present and its value is not the empty string.</li> | |
| <li>Otherwise use `alt` attribute if present and its value is not an empty string.</li> |
| <!-- NOTE: use of value attribute is invalid on input type=image, but it DOES contribute to the name if used --> | ||
| <!-- <li>Otherwise use `value` attribute.</li> --> | ||
| <li>Otherwise use `title` attribute.</li> | ||
| <li>Otherwise use `title` attribute if present and its value is not the empty string.</li> |
There was a problem hiding this comment.
Suggested change
| <li>Otherwise use `title` attribute if present and its value is not the empty string.</li> | |
| <li>Otherwise use `title` attribute if present and its value is not an empty string.</li> |
Member
Author
There was a problem hiding this comment.
Don’t disagree, but I’m not going to break convention with how this concept is consistently referred to in specs.
accdc
approved these changes
Jul 27, 2023
cookiecrook
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds clarifying language for the alt and title steps.
updates the localized text string step to better match the updated input type=button/reset/submit, and note the fact that this element is considered a 'submit button' - linking to that portion of the HTML spec and noting that different browsers may provide a different default string (e.g., chrome does 'submit' while firefox does 'submit query')
Closes #414
Preview | Diff