javascript function in a for loop not causing crashing browser

Question

I'm new at coding and am trying to figure out why this doesn't work. the function works fine I'm assuming there is a fundamental flaw in the sumArray function that is not processing

// SET UP FUNCTIONS FOR LATER USE   

// sumArray - takes all values within an array and adds them 
var sumArray = function(x){
    var sum = 0;
    for(i=0;i<x.length;i++) {
        sum += parseInt(x[i]);
    };
    return sum;     
};

// create an array and use sumArray function inside of a loop.

// This works
var arrayTest = new Array(1,2,3,4,5,6,7,8,9,10);
document.write (sumArray(arrayTest);

// This crashes the browser
for(i=0;i<10;i++){
document.write("<br/>" + sumArray(arrayTest) + "<br/>"); 
};

Thanks in advance for any insight.

You should [1, 2, 3 ...] instead of new Array(1, 2, 3 ... ) — Waleed Khan
– Waleed Khan, Commented Oct 5, 2012 at 17:20
The term "crash the browser" means that the entire browser process fails. Is that what's happening? — Pointy
– Pointy, Commented Oct 5, 2012 at 17:22
And you should accept both answers, which will crash not only your browser, but will cause the whole universe collapse. ;-) — Michael Krelin - hacker
– Michael Krelin - hacker, Commented Oct 5, 2012 at 17:22

Pointy · Accepted Answer · 2012-10-05 17:19:34Z

4

You need to declare "i" with var:

for(var i=0;i<10;i++){

in both loops. If you don't do that, there's just one global "i" clobbered by both loops.

answered Oct 5, 2012 at 17:19

Pointy

415k62 gold badges600 silver badges632 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Pointy Over a year ago

It won't "crash the browser" in this case but it will make thinks work incorrectly.

Michael Krelin - hacker Over a year ago

Well, nothing should "crash the browser" short of browser bug.

I Hate Lazy Over a year ago

Yeah, I guess it would only cause the main loop to run only once, but certainly needs to be fixed.

I Hate Lazy · Accepted Answer · 2012-10-05 17:19:43Z

4

Just before the second loop, you're missing a ).

document.write (sumArray(arrayTest) ); // <-- right here

Additionally, be very careful with document.write. If it runs while the document is loading, you'll probably be alright. Be sure you don't use it after the doc has loaded.

answered Oct 5, 2012 at 17:19

I Hate Lazy

49k13 gold badges89 silver badges79 bronze badges

Collectives™ on Stack Overflow

javascript function in a for loop not causing crashing browser

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related