bash scripting if condition error

Question

This is my first bash script to sync my contents to the server. I want to pass the folder to be synced as a parameter. However, it does not work as expected.

This is my script (saved as sync.sh):

echo "STARTING SYNCING... PLEASE WAIT!"
var="$1" ;
echo "parameter given is $var"

if [ "$var"=="main" ] || [ "$var"=="all" ] ; then
    echo "*** syncing  main ***" ;
    rsync -Paz /home/chris/project/main/ user@remote_host:webapps/project/main/ 
fi

if [ "$var"=="system" ] || [ "$var"=="all" ] ; then
    echo "*** syncing  system ***" ;
    rsync -Paz /home/chris/project/system/ user@remote_host:webapps/project/system/ 
fi

if [ "$var"=="templates" ] || [ "$var"=="all" ] ; then
    echo "*** syncing  templates ***" ;
    rsync -Paz /home/chris/project/templates/ user@remote_host:webapps/project/templates/ 
fi

And this my output:

chris@mint-desktop ~/project/ $ sh ./sync.sh templates
STARTING SYNCING... PLEASE WAIT!
parameter given is templates
*** syncing  main ***
^Z
[5]+  Stopped                 sh ./sync.sh templates

Although I gave "templates" as an argument, it ignores it. Why?

dogbane · Accepted Answer · 2012-11-08 08:44:07Z

2

You need a space on either side of the == operator. Change it to:

if [ "$var" == "main" ] || [ "$var" == "all" ] ; then
    echo "*** syncing  main ***" ;
    rsync -Paz /home/chris/project/main/ user@remote_host:webapps/project/main/ 
fi

answered Nov 8, 2012 at 8:44

dogbane

276k77 gold badges407 silver badges415 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

xpanta Over a year ago

Thanks. I used to have spaces around == but I was getting this:

STARTING SYNCING... PLEASE WAIT! parameter given is templates ./sync.sh: 5: [: templates: unexpected operator ./sync.sh: 5: [: templates: unexpected operator ./sync.sh: 10: [: templates: unexpected operator ./sync.sh: 10: [: templates: unexpected operator ./sync.sh: 15: [: templates: unexpected operator ./sync.sh: 15: [: templates: unexpected operator ./sync.sh: 20: [: templates: unexpected operator ./sync.sh: 20: [: templates: unexpected operator

Joakim Nohlgård · Accepted Answer · 2012-11-08 09:06:32Z

0

Based on the comments below, this is my suggested corrected script:

#!/bin/bash
echo "STARTING SYNCING... PLEASE WAIT!"
var="$1" ;
echo "parameter given is $var"

if [ "$var" == "main" -o "$var" == "all" ] ; then
    echo "*** syncing  main ***" ;
    rsync -Paz /home/chris/project/main/ user@remote_host:webapps/project/main/ 
fi

if [ "$var" == "system" -o "$var" == "all" ] ; then
    echo "*** syncing  system ***" ;
    rsync -Paz /home/chris/project/system/ user@remote_host:webapps/project/system/ 
fi

if [ "$var" == "templates" -o "$var" == "all" ] ; then
    echo "*** syncing  templates ***" ;
    rsync -Paz /home/chris/project/templates/ user@remote_host:webapps/project/templates/ 
fi

edited Nov 8, 2012 at 9:06

answered Nov 8, 2012 at 8:42

Joakim Nohlgård

1,86016 silver badges16 bronze badges

6 Comments

anishsane Over a year ago

[ "$var" == "main" || "$var" == "all" ] should be changed to [ "$var" == "main" -o "$var" == "all" ]

dogbane Over a year ago

or it can be changed to use double brackets i.e. [[ "$var" == "main" || "$var" == "all" ]]

Joakim Nohlgård Over a year ago

You are correct, I didn't test my script (I was at the wrong computer). I'll make sure to test before I post in the future. I have corrected my solution.

xpanta Over a year ago

Thanks, I tried that too. But I still get a similar error as the one I get when I apply @dogbane's suggestion:

STARTING SYNCING... PLEASE WAIT! parameter given is templates ./sync.sh: 5: [: templates: unexpected operator ./sync.sh: 10: [: templates: unexpected operator ./sync.sh: 15: [: templates: unexpected operator ./sync.sh: 20: [: templates: unexpected operator

Joakim Nohlgård Over a year ago

Are you really running bash? Did you put #!/bin/bash at the top of the script or run it as bash sync.sh?

|

Collectives™ on Stack Overflow

bash scripting if condition error

2 Answers 2

1 Comment

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related