Adding a Unique Element to an Array

Question

I have an array of objects called seasons of length 300, and I trying to search through a certain property "Date" and add it to an array if it has not been found before. So far I have

var day=[];
for (var i=1; i<300; i++) {
    var found=false;
    for (var j=0; j<day.length; j++) {
        if (day[j]==seasons[i]["Date"]) {
            found=true;
            break;
        }
        if (!found) {
            day[day.length]=seasons[i]["Date"];
        }
    }
}

I'm not too sure where this is going wrong, and would appreciate some help. Thanks

Kijewski · Accepted Answer · 2013-11-09 14:47:20Z

1

You break out of the inner for-loop, so the if (!found) block is never executed.

Just put it after the inner loop:

for (var i = 1; i < 300; i++) {
    var found = false;
    for (var j = 0; j < day.length; j++) {
        if (day[j] == seasons[i]["Date"]) {
            found = true;
            break;
        }
    }
    if (!found) {
        day[day.length] = seasons[i]["Date"];
    }
}

Or do it in the if-block:

for (var i = 1; i < 300; i++) {
    for (var j = 0; j < day.length; j++) {
        if (day[j] == seasons[i]["Date"]) {
            day[day.length] = seasons[i]["Date"];
            break;
        }
    }
}

I guess the latter solution is easier to understand.

edited Nov 9, 2013 at 14:47

answered Nov 9, 2013 at 14:42

Kijewski

26.1k14 gold badges108 silver badges149 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user1636522 Over a year ago

@user10319 You may also replace day[day.length]=seasons[i]["Date"]; with day.push(seasons[i]["Date"]);, it's a bit smaller to write and easier to read :)

Collectives™ on Stack Overflow

Adding a Unique Element to an Array

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related