PHP in_array does not check all cases

Question

I'm removing values from an array in PHP use an in_array check yet for some reason it does not want to check through the entire length of the exclude array. Running this code it removes the Dodge entries from the array but not the Toyota, why is this?

<?php

    $inventory = array(
        '0' => Array
            (
                'car_name' => 'Dodge',
                'set_name' => 'A',
                'edition' => 'B41',
                'location' => 'Houston'
            ),

        '1' => Array
            (
                'car_name' => 'Dodge',
                'set_name' => 'A',
                'edition' => 'B41',
                'location' => 'Houston'
            ),

        '2' => Array
            (
                'car_name' => 'Dodge',
                'set_name' => 'A',
                'edition' => 'B41',
                'location' => 'Houston'
            ),

        '3' => Array
            (
                'car_name' => 'Dodge',
                'set_name' => 'A',
                'edition' => 'VarA31',
                'location' => 'Houston'
            ),

        '4' => Array
            (
                'car_name' => 'Toyota',
                'set_name' => 'A',
                'edition' => 'VarA31',
                'location' => 'Houston'
            ),

        '5' => Array
            (
                'car_name' => 'Toyota',
                'set_name' => 'A',
                'edition' => 'VarA31',
                'location' => 'Houston'
            ),

        '6' => Array
            (
                'car_name' => 'Toyota',
                'set_name' => 'A',
                'edition' => 'VarA31',
                'location' => 'Houston'
            ),

        '7' => Array
            (
                'car_name' => 'Toyota',
                'set_name' => 'A',
                'edition' => 'VarA31',
                'location' => 'Houston'
            ),

        '8' => Array
            (
                'car_name' => 'Toyota',
                'set_name' => 'A',
                'edition' => 'VarA31',
                'location' => 'Houston'
            ),

        '9' => Array
            (
                'car_name' => 'Toyota',
                'set_name' => 'A',
                'edition' => 'VarA31',
                'location' => 'Houston'
            ),

        '10' => Array
            (
                'car_name' => 'Toyota',
                'set_name' => 'A',
                'edition' => 'VarA31',
                'location' => 'Houston'
            ),

        '11' => Array
            (
                'car_name' => 'Toyota',
                'set_name' => 'A',
                'edition' => 'VarA31',
                'location' => 'Houston'

            ),
    );

    $exclude = array('Dodge','Toyota');

    for($k=0; $k<sizeof($inventory); $k++)
    {
    if(in_array(trim($inventory[$k]['car_name']), $exclude))
    {   unset($inventory[$k]);}

    }

         $inventory = array_values($inventory);
         echo '<pre>';
         print_r($inventory);
         echo '</pre>';



    ?>

in_array() does not work on multidimensional arrays. Possible duplicate of this question — AndrewVT
– AndrewVT, Commented Dec 28, 2014 at 0:33
@user2058037 - in_array is being used on the $exclude array here, where it will work — Mark Baker
– Mark Baker, Commented Dec 28, 2014 at 0:34
This is a good example of why incremental for loops are not often used in languages supporting some kind of foreach construct. If you did this via foreach ($inventory as $k => $v) you'll find it much easier to manage. — Michael Berkowski
– Michael Berkowski, Commented Dec 28, 2014 at 0:41
think of it this way - if you have to "do a thing N times", use an incremental for loop. If you have to "do a thing to each element in a collection", choose a foreach instead. — Michael Berkowski
– Michael Berkowski, Commented Dec 28, 2014 at 0:43

Mark Baker · Accepted Answer · 2014-12-28 00:41:53Z

1

Your problem is that unsetting an element from an enumerated array will adjust the size of your array, but testing using sizeof() to see if you should exit your loop, so each iteration where you unset will reduce the number of values left to test.

$exclude = array('Dodge','Toyota');

$size = sizeof($inventory);
for($k=0; $size; $k++) {
    if(in_array(trim($inventory[$k]['car_name']), $exclude)) {
        unset($inventory[$k]);
    }
}

$inventory = array_values($inventory);
echo '<pre>';
print_r($inventory);
echo '</pre>';

edited Dec 28, 2014 at 0:41

answered Dec 28, 2014 at 0:36

Mark Baker

213k34 gold badges354 silver badges390 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Juank · Accepted Answer · 2014-12-28 00:44:05Z

1

You are removing the index:value pair from the array, while iterating it. So after unsetting a value the index positions dont match or even exist.

Try copying the values you do need, into a new empty array like this:

$exclude = array('Dodge','Toyota');
$filtered = array();

for($k=0; $k<sizeof($inventory); $k++){
    if(in_array(trim($inventory[$k]['car_name']), $exclude)){
        // dont do this because it is changing the count of elements in the array unset($inventory[$k]);
    } else {
        $filtered[] = $inventory[$k]; // push the desired values into a new array
    }
}

echo '<pre>';
print_r($filtered);  // this should have the values that don't have 'Dodge' or 'Toyota'
echo '</pre>';

Edit: Mark's answer would be the best way to go cause it is also better performance wise

edited Dec 28, 2014 at 0:44

answered Dec 28, 2014 at 0:38

Juank

6,2661 gold badge30 silver badges29 bronze badges

3 Comments

Michael Berkowski Over a year ago

Unsetting an array index in PHP has no effect on the numbers of subsequent indexes.

Michael Berkowski Over a year ago

It's the sizeof() at fault.

Juank Over a year ago

yeah, after unsetting, the recalculation of sizeof() in the loop gets messed up

Peter · Accepted Answer · 2014-12-28 00:45:49Z

1

use foreach instead for($k=0; $k<sizeof($inventory); $k++):

foreach($inventory as $k => $row)

this is because while you are unsetting $inventory you skip elements

$k = 0, sizeof($inventory) = 12, you unset one of the items, $k++. $inventory[1] becomes $inventory[0]

$k = 1, sizeof($inventory) is now 11, you check $inventory[1] but not $inventory[0] (previous known as $inventory[1])

edited Dec 28, 2014 at 0:45

answered Dec 28, 2014 at 0:40

Peter

17k9 gold badges55 silver badges77 bronze badges

Collectives™ on Stack Overflow

PHP in_array does not check all cases

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related