How to share a variable between error and success callback of angular http request

Question

i want to share a variable between both methods of $http.get request of angular js my code looks like this

app.run(function($rootScope,$http) {
$rootScope.checkSession = function(){
  window.a = false;
    $http.get('/data/url')
    .success(function(response) {
      window.a = true;
    })
    .error(function(response){
      window.a = false;
    });
    return window.a;
};
});

and my controller code looks like this

app.controller('profileController', function($scope, $rootScope) {
   alert($rootScope.checkSession());
});

it is always output false while if i alert response in both functions it works fine.

window.a is returned before success or error comes.. this is wrong approach — ramamoorthy_villi
– ramamoorthy_villi, Commented Nov 4, 2015 at 18:58

Maarten · Accepted Answer · 2015-11-04 18:56:57Z

3

You are confusing returns and promises. The window.a will be set async at the time your promise ($http.get) resolves, and by that time your return with the initial value has already been returned and used by alert().

answered Nov 4, 2015 at 18:56

Maarten

4,6677 gold badges39 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pankaj Parkar · Accepted Answer · 2015-11-04 19:09:40Z

2

The way your are doing is not the correct way of dealing with asynchronous call, as per current implementation it will always return false from that checkSession method. You need to return promise from that method which dealing with asynchronously. That promise will return data from its resolve & reject.

Additional thing is, I would love to have this code inside a factory, rather than having in inside $rootScope.

Factory

app.factory('sessionFactory', function($http) {
  var sessionFactory = {}
  sessionFactory.checkSession = function(){
    return $http.get('/data/url')
    .then(function(response) {
      return true;
    },(function(response){
      return false;
    });
  };
  return sessionFactory;
});

So for using it in controller, you 1st need to inject sessionFactory on your controller factory function & then use checkSession method on it. Inside .then of that method you will have returned data.

Controller

app.controller('profileController', function($scope, sessionFactory) {
   sessionFactory.checkSession().then(function(data){
      alert(data);
   });
});

edited Nov 4, 2015 at 19:09

answered Nov 4, 2015 at 18:57

Pankaj Parkar

136k23 gold badges241 silver badges307 bronze badges

3 Comments

Maarten Over a year ago

good example, just be aware that alert() probably won't work correctly with the promise.

Pankaj Parkar Over a year ago

@Maarten look at edit..Actually I was converting it to factory..to make that checkSession method rather than pollution $rootScope

Pankaj Parkar Over a year ago

@VivekMaru do look at updated which has better explaination... Glad to help you.. :)

Collectives™ on Stack Overflow

How to share a variable between error and success callback of angular http request

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related