Javascript replace function "is not a function"

Question

I have an issue with the following code. I want to replace a string by another one, and generate an img code. However, I got an error message: str.replace is not a function. Any idea why?

    <input type="text" id="text">
    <input type="button" value="See Code" onclick="myFunction();">
    <input type="text" id="code" name="code">

<script>
    function myFunction() {
        var str = parseInt(document.getElementById("text").value);
        var res = str.replace("ftpadress", "htmladress");
        var code = str.concat("<img src='",res,"' width='100%'>");
        document.getElementById("code").value = code;
        }
</script>

str is result of parseInt, so ,it's a number. .replace() is a String method. — luiscrjr
– luiscrjr, Commented Feb 8, 2017 at 1:13
Possible duplicate of Why do I get an error message that .replace is not a function? — Sebastian Simon
– Sebastian Simon, Commented Feb 8, 2017 at 1:22
Why are you calling parseInt() on a value that might contain the string "ftpadress"? — nnnnnn
– nnnnnn, Commented Feb 8, 2017 at 2:14

karuhanga · Accepted Answer · 2019-02-14 20:13:23Z

7

As @mrlew pointed out, str is result of parseInt and therefore, it's a number. replace() is a string method, so it will not work on a number.

If I understood correctly, you would like to replace a string, retrieve a code and then generate an image tag with the new string and code.

I'd go with...

<input type="text" id="text" />
<input type="button" value="See Code" onclick="myFunction();">
<input type="text" id="code" name="code">

<script>
function myFunction() {
    //changed
    var str = document.getElementById("text").value; //get text
    var res = str.replace("ftpadress", "htmladress"); //replace
    var code = parseInt(str).toString(); //get code and cast it back to a string
    document.getElementById("code").value = code; //insert code
    var withTag = code.concat("<img src='", res, "' width='100%'>"); //generate tag
}
</script>

edited Feb 14, 2019 at 20:13

answered Feb 8, 2017 at 1:55

karuhanga

3,3321 gold badge30 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Fady Sadek · Accepted Answer · 2017-02-08 01:14:05Z

1

parseInt returns an integer not a string so you can not use str.replace() , you need to cast it first

just add str = str.toString(); before using the replace function

answered Feb 8, 2017 at 1:14

Fady Sadek

1,1601 gold badge13 silver badges23 bronze badges

1 Comment

Amadan Over a year ago

I doubt very much that OP will find "ftpaddress" in a re-stringified integer. Something's fishy.

iwaduarte · Accepted Answer · 2017-02-08 01:20:59Z

1

Just remove the casting (parseInt function) and everything should work fine.

 <input type="text" id="text">
    <input type="button" value="See Code" onclick="myFunction();">
    <input type="text" id="code" name="code">

<script>
    function myFunction() {
        //changed
        var str = document.getElementById("text").value;
        console.log(str);
        var res = str.replace("ftpadress", "htmladress");
        var code = str.concat("<img src='",res,"' width='100%'>");
        document.getElementById("code").value = code;
        }
</script>

answered Feb 8, 2017 at 1:20

iwaduarte

1,74919 silver badges26 bronze badges

1 Comment

Flo Over a year ago

Thank you so much! Didn't realize parseInt had this effect.

Collectives™ on Stack Overflow

Javascript replace function "is not a function"

3 Answers 3

Comments

1 Comment

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related