angularjs make json to array and use in a factory

Question

This is the factory I use right now, I get 2 json objects and try to do a array of them then I cant use it in the textreplacer.

app.factory('myFactory', function ($http) {
  var service = {}
  var array =  [];
  var obj = [];


  service.getText = function () {
    return text =  $http.get('api/json_text').then(function(res){
        return res.data;
    });
  }
  service.getShortcuts = function () {
    return shortcuts = $http.get('api/json_shortcuts').then(function(res){
        return res.data;
    });
  }
  service.merchJson = function () {
    service.getText().then(function(text) {
      service.getShortcuts().then(function(shortcuts) {
        angular.forEach(text, function(value, key) {
          if(!angular.isUndefined(shortcuts[value])){
            array_value = shortcuts[value];
            obj[key] = array_value;
            array.push(obj[key]);
          }else{
            array_value = text[key].toString();
            obj[key] = array_value;
            array.push(obj[key]);
          }
        });

      });
    });
    return array;
  }
  service.textReplacer = function () {
      var array = service.merchJson();
      angular.forEach(array, function(value, key) {

      });
      console.log(array);

  }
  return service;
})

Is it something I done wrong or a bug because I can see it in console.log(array) without any problem.

your array is inside asynchronous callbacks, you can't return it like a normal variable. Once a Promise is always a Promise — Aleksey Solovey
– Aleksey Solovey, Commented Mar 7, 2018 at 15:40

Rahul Sharma · Accepted Answer · 2018-03-07 16:04:37Z

0

try this

service.merchJson = function () {
    var result;
    return service.getText().then(function (text) {
            result = text;
            return service.getShortcuts();
        })
        .then(function (shortcuts) {
            angular.forEach(result, function (value, key) {
                if (!angular.isUndefined(shortcuts[value])) {
                    array_value = shortcuts[value];
                    obj[key] = array_value;
                    array.push(obj[key]);
                } else {
                    array_value = result[key].toString();
                    obj[key] = array_value;
                    array.push(obj[key]);
                }
            });
            return array;
        });
}


service.textReplacer = function () {
    service.merchJson().then(function (array ) {
        angular.forEach(array, function (value, key) {});
        console.log(array);
    });
}

edited Mar 7, 2018 at 16:04

answered Mar 7, 2018 at 15:37

Rahul Sharma

10.1k1 gold badge20 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Aleksey Solovey Over a year ago

text is not within the scope for the second .then I think

Daniel Dehlin Over a year ago

so that it was from the controller now becouse it wasent a return there but i only get this now

Daniel Dehlin Over a year ago

f {$$state: {…}}$$state:

Daniel Dehlin Over a year ago

TypeError: Cannot read property 'toString' of undefined at editor.js:30

Daniel Dehlin Over a year ago

array_value = text[key].toString();

|

Collectives™ on Stack Overflow

angularjs make json to array and use in a factory

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related