JavaScript If conditional statement not screening input values

Question

I am working on a pre-BootCamp problem. I am taking an object and removing any properties that have odd numeric values, and then returning the object. Why are the odd values not being filtered out?

/*
Write a function called "removeOddValues".

Given an object, "removeOddValues" removes any properties whose valuse are odd numbers.

var obj = {
  a: 2,
  b: 3,
  c: 4
};
removeOddValues(obj);
console.log(obj); // --> { a: 2, c: 4 }
*/

function removeOddValues(obj) {
  for (var values in obj) {
      if (obj[values] === 'Number' && obj[values] % 2 !== 0) {
           delete obj[values]
      }  
      }   
      return obj;
};


var obj = {
  a: 2,
  b: 3,
  c: 4
};


removeOddValues(obj);

output:
{a: 2, b: 3, c: 4}

Luca Kiebel · Accepted Answer · 2018-08-11 20:29:01Z

3

They are not being removed since the If-statement you constructed doesn't evaluate to true for the conditions you have.

I think you are missing a typeof in the first condition. Your if-statement should read as follows:

if ((typeof obj[values]) === 'number' && obj[values] % 2 !== 0) ...

With that fixed, your code runs just fine:

function removeOddValues(obj) {
  for (var values in obj) {
    if ((typeof obj[values]) === 'number' && obj[values] % 2 !== 0) {
      delete obj[values]
    }
  }
  return obj;
};


var obj = {
  a: 2,
  b: 3,
  c: 4
};


console.log(removeOddValues(obj))

answered Aug 11, 2018 at 20:29

Luca Kiebel

10.1k7 gold badges34 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

LittleShell Over a year ago

Thank you Luca! You are right, I was missing 'typeof.'

Luca Kiebel Over a year ago

And the type of a Number is "number", not "Number" ;-)

michaelitoh · Accepted Answer · 2018-08-11 20:31:15Z

0

Just use this:

function removeOddValues(obj) {
  for (var values in obj) {
      if (typeof obj[values] === 'number' && obj[values] % 2 !== 0) 
           delete obj[values]           
  }   
  return obj;
};

answered Aug 11, 2018 at 20:31

michaelitoh

2,34016 silver badges26 bronze badges

Collectives™ on Stack Overflow

JavaScript If conditional statement not screening input values

2 Answers 2

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related