Windows Git Bash Script string concatenation not working

Question

I have been trying to execute a bash script which works perfect in MacOS but showing weird behavior in windows git bash. Bash script is trying to read from yaml file and print the string for this example.

Git bash version:

GNU bash, version 4.4.23(1)-release (x86_64-pc-msys)
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

Yaml File (values.yaml):

apis:
  api1:
    image:
      repository: xxxx.azurecr.io/api1
  api2:
    image:
      repository: xxxx.azurecr.io/api2
  api3:
    image:
      repository: xxxx.azurecr.io/api3

Bash Script:



function pull_apis () {
    local apps=$(yq ".apis | keys" - < ./values.yaml -o json | jq -n 'inputs[]' --raw-output)
    for i in ${apps[@]}
    do
        echo $i
        echo "yq .$i.image.repository - < ./values.yaml"        
        repository=$(yq ".apis.$i.image.repository" - < ./values.yaml)
        echo "----  $repository"
    done
}

pull_apis

It shows below result

api1
.image.repository - < ./values.yaml
----  null
api2
.image.repository - < ./values.yaml
----  null
api3
yq .api3.image.repository - < ./values.yaml
----  xxxx.azurecr.io/api3

Expected result:

api1
yq .api1.image.repository - < ./values.yaml
----  xxxx.azurecr.io/api1
api2
yq .api2.image.repository - < ./values.yaml
----  xxxx.azurecr.io/api2
api3
yq .api3.image.repository - < ./values.yaml
----  xxxx.azurecr.io/api3

I have tried with static array and it works. However, it doesn't work when it reads keys from file.

Could some expert please shade some light on missing part?

Check your script with shellcheck.net to see if there are any obvious issues or warnings. — Paul T.
– Paul T., Commented Jul 20, 2022 at 4:11
@PaulT. As I said, script is already been tested in MacOs and it is working. Issue is with Windows git bash only. I have also check the EOL in yaml file and made it LF to see if that was causing problem. But it is not. However, I will check on your suggested link. — Ajay
– Ajay, Commented Jul 20, 2022 at 4:20
Your line echo "yq .$i.image.repository - < ./values.yaml" should print yq ...., yet the "yq" is gone. This usually indicates that there are some weird characters (i.e. control characters, non-printable, ...) in $i. You could inspect the values with echo "$i" | od -c. Gut feeling, $i is not clean. — Nic3500
– Nic3500, Commented Jul 20, 2022 at 4:28
I'd put set -x at the beginning of the script to get an execution trace as it runs -- that often clarifies what's going wrong. Also, I second the recommendation of shellcheck.net even if the script seems to be running fine, since it has several quoting problems that could cause trouble even if they aren't right now. — Gordon Davisson
– Gordon Davisson, Commented Jul 20, 2022 at 4:33
Unless things have changed, MacOS's default shell is not bash — xpusostomos
– xpusostomos, Commented Jul 20, 2022 at 6:47

Ajay · Accepted Answer · 2022-07-20 04:48:47Z

1

Thanks @Gordon to point me out to check execution trace. After putting set -x, it shows me the wrong thing happening.

++ pull_apis
++ local apps
+++ yq '.apis | keys' - -o json
+++ jq -n 'inputs[]' --raw-output
++ apps='api1
api2
api3'
++ for i in ${apps[@]}
++ echo $'api1\r'
api1

++ echo $'api1\r' this value was coming with \r. I am able to fix my script after removing it as below,

function pull_apis () {
    local apps=$(yq ".apis | keys" - < ./values.yaml -o json | jq -n 'inputs[]' --raw-output)
    for i in ${apps[@]}
    do
        local param="${i/$'\r'/}"
        echo "$param"        
        echo "yq .$param.image.repository - < ./values.yaml"        
        repository=$(yq ".apis.$param.image.repository" - < ./values.yaml)
        echo "----  $repository"
    done
}

pull_apis

answered Jul 20, 2022 at 4:48

Ajay

5543 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Gordon Davisson Over a year ago

That's almost certainly due to the values.yaml file having DOS/Windows-style line endings; see "Are shell scripts sensitive to encoding and line endings?" for info about how to fix this. BTW, apps isn't an array, it's a string with newlines, so ${apps[@]} isn't doing anything useful.

Ajay Over a year ago

@GordonDavisson Yes. I was just trying to see if that make my script work. ${app[@]} is not useful but it works in this case as well.

Collectives™ on Stack Overflow

Windows Git Bash Script string concatenation not working

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related