Server output hook #201
Merged
Server output hook #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It mostly works for me. The one issue I have seen is that if I try to print anything outside of any if statement, the server crashes on plugin load. I'm certain it is because I'm causing an infinite loop and nothing can really be done about that, but we should at least add documentation around that. |
Member
Author
|
Yeah, I guess printing shouldn't be done at all in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a server console output hook (
OnServerOutput). You can decide whether you want to block the message from being printed or not.Moreover, this adds a new context manager (
server_output), which allows to intercept all messages sent during the execution of the with-statement. This allows e.g. to retrieve the output of server commands.I have tested this with CS:S, Blade, CS:GO, L4D2 and BM:S on Windows and with CS:GO on Linux. Everything seems to work fine. But I would also like you to take a look at it before merging it into the master.