Skip to content

Conversation

@Ayuto
Copy link
Member

@Ayuto Ayuto commented Jan 14, 2018

With this PR many dynamic attributes (all attributes from the shared CBaseEntity.ini) that were used to be accessed via the Entity class are moved to BaseEntity. These properties are now added statically, which has multiple reasons:

  • Provide more functionality for the BaseEntity class.
  • These (basic) properties are now getting documented on the Wiki.
  • Major performance improvements (accessing these attributes from BaseEntity and all of its subclasses is up to 120 times faster).
  • Some properties now return the correct value (e. g. move_type now returns MoveType instead of int)

@Ayuto Ayuto merged commit ca83e29 into master Jan 14, 2018
@Ayuto Ayuto deleted the entity_changes branch January 14, 2018 20:36
@Ayuto Ayuto mentioned this pull request Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants