Fixed AttributeError when displaying plugin list.

[CookStar]

No description provided.

[Ayuto]

Which issue does this solve? Could you please add a few steps to reproduce the issue?

[jordanbriere]

Which issue does this solve? Could you please add a few steps to reproduce the issue?

It cause an error if it is set to False and wasn't overwritten by a ConVar on plugin load. Basically, it will never explicitely be None, either False or a ConVar if it was True when the plugin was loaded (which should always be the case for iterated plugins by sp plugin list). If you have the following in your info.ini:

public_convar = 0

Then the following error will raise when using sp plugin list:

AttributeError: 'bool' object has no attribute 'name'

However, a proper fix should rather be:

            if isinstance(info.public_convar, ConVar):

Because we implemented ConVar.__bool__ which will evaluates to False if the value cannot be interpreted as 1/0 resulting into the variables no longer be listed in the output. For example, this would prints False, although is a valid versioning variable:

print(bool(ConVar('foo', '0.1')))

[CookStar]

Which issue does this solve? Could you please add a few steps to reproduce the issue?

I apologize for the lack of explanation.

It cause an error if it is set to False and wasn't overwritten by a ConVar on plugin load. Basically, it will never explicitely be None, either False or a ConVar if it was True when the plugin was loaded (which should always be the case for iterated plugins by sp plugin list). If you have the following in your info.ini:

public_convar = 0

Then the following error will raise when using sp plugin list:

AttributeError: 'bool' object has no attribute 'name'

As jordanbriere wrote above, that's the problem.

However, a proper fix should rather be:

            if isinstance(info.public_convar, ConVar):

Because we implemented ConVar.__bool__ which will evaluates to False if the value cannot be interpreted as 1/0 resulting into the variables no longer be listed in the output. For example, this would prints False, although is a valid versioning variable:

print(bool(ConVar('foo', '0.1')))

Oh, I didn't know about ConVar's behavior.
Changed to check PublicConVar's classinfo.