Fixes to menus package. #70
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes menuselect 0/10 for CSS update: 16/09/2015 CSS update seems to make the client send menuselect 10 instead of menuselect 0, however it seems to still get handled as menuselect 0 by SP even when BUTTON_CLOSE and VALID_CHOICES are updated to resemble this change, this should be a quick fix to address this issue and make menuselect 0/10 work again. It might be a bit of a dirty fix but this worked on my client/server. Fixes updated ClientCommand register: The ClientCommand register arguments were changed, this package got forgotten. Note: I did swap passed arguments in the callbacks to keep it simple, this might be undesireable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes menuselect 0/10 for CSS update:
16/09/2015 CSS update seems to make the client send menuselect 10 instead of menuselect 0, however it seems to still get handled as menuselect 0 by SP even when BUTTON_CLOSE and VALID_CHOICES are updated to resemble this change, this should be a quick fix to address this issue and make menuselect 0/10 work again. It might be a bit of a dirty fix but this worked on my client/server.
Fixes updated ClientCommand register:
The ClientCommand register arguments were changed, this package got forgotten.
Note: I did swap passed arguments in the callbacks to keep it simple, this might be undesireable.