Skip to content

Kwargs and return values to filters and hooks' __call__ #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ayuto merged 2 commits into from
Dec 6, 2015
Merged

Kwargs and return values to filters and hooks' __call__ #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8863c23
Merge remote-tracking branch 'refs/remotes/Source-Python-Dev-Team/mas…
Mahi Dec 6, 2015
3b18318
Added kwargs and return values to filters and hooks
Mahi Dec 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addons/source-python/packages/source-python/commands/filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ def __init__(self, callback):
# Register the filter
self._manager_class.register_filter(self.callback)

def __call__(self, *args):
def __call__(self, *args, **kwargs):
"""Call the callback."""
self.callback(*args)
return self.callback(*args, **kwargs)

def _unload_instance(self):
"""Unregister the filter."""
Expand Down
4 changes: 2 additions & 2 deletions addons/source-python/packages/source-python/hooks/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ def __init__(self, callback):
self.callback = callback
self._class_instance.append(self.callback)

def __call__(self, *args):
def __call__(self, *args, **kwargs):
"""Call the callback."""
self.callback(*args)
return self.callback(*args, **kwargs)

def _unload_instance(self):
"""Unregister the hook."""
Expand Down